Skip to content

Extension/separated tools#171

Open
andrewphilipsmith wants to merge 29 commits intomasterfrom
extension/separated_tools
Open

Extension/separated tools#171
andrewphilipsmith wants to merge 29 commits intomasterfrom
extension/separated_tools

Conversation

@andrewphilipsmith
Copy link
Copy Markdown
Contributor

Fixes #

Proposed Changes

@harry-gibson
Copy link
Copy Markdown
Contributor

fixed conflict with MapAction.csproj: this branch has renamed it to MapAction_core.csproj and meantime a new line had been added to the file on master.

Removed failing attempt to copy apparently-redundant RenameLayer addin, updated output path for main addin to reflect new project name, add attempt to copy output MSI file (but expect this to fail as GOCD may not be able to produce the MSI)
REM'd out the copy of the non-existent MSI (it did indeed fail on GOCD)
@harry-gibson
Copy link
Copy Markdown
Contributor

harry-gibson commented Mar 4, 2020

Need to make some updates to GOCD:

  • Cannot build the installer project using MSBuild, so need to call devenv (the visual studio executable) to do it instead (http://techproblemssolved.blogspot.com/2009/05/msbuild-and-vdproj-files.html)

  • e.g. C:\Program Files (x86)\Microsoft Visual Studio\2017\Community>DevEnv "C:\Users\zool1301\Documents\GitHub\mapaction-toolbox\arcgis10_mapping_tools\MapAction-toolbox.sln" /build "Release|Any Cpu"

  • This in turn fails due to a bug with out of process building of installer projects (https://stackoverflow.com/questions/8648428/an-error-occurred-while-validating-hresult-8000000a). To fix this a registry key needs to be added, and there is a helper exe installed with visual studio to do this (!): C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\CommonExtensions\Microsoft\VSI\DisableOutOfProcBuild\DisableOutOfProcBuild.exe (https://stackoverflow.com/a/45580775)

  • The final convolution is that the helper exe cannot simply be called, because it only works if called from its own folder! So you have to CD to its folder, call it, then CD back to where you were. So we use the batch file created by this lovely person to do that: https://stackoverflow.com/a/41788791.

  • So GOCD needs to call that first (no harm in repeating each time) before calling the devenv command. Helper script added and make.cmd updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants